[FFmpeg-devel] [PATCH] Patch cleanup for MPEG 1 & 2 optimizations

[Michael Niedermayer]

On Mon, Apr 14, 2008 at 10:53:42AM -0400, Jeff Downs wrote:
> On Sun, 13 Apr 2008, Jeff Downs wrote:
> 
> > MPV_motion_internal is no longer inlined (max-inline-insns-single limit 
> > reached).  Trying to increase that limit to double the gcc man page stated 
> > default did nothing to help. Limit was still reached.
> > 
> > Adding av_always_inline to it makes it be inlined. MPV_motion is still not 
> > (though I don't know if it is in current svn either).
> > This (and fixing the aforementioned typo) gets performance closer to what 
> > I posted for the hardcoded version.
> > 
> 
> OP's patches with the addition of av_always_inline to MPV_motion and 
> fixing the typo in the calls to MPV_decode_mb are attached.
> 
> Here are benchmarks for these three patches (together).  10 runs each 
> on Core 2 duo:
> 
> MPEG1 Current SVN:
> User: avg: 0.201  stddev: 0.003  med: 0.200
> Real: avg: 0.203  stddev: 0.003  med: 0.202
> 
> MPEG1 w/ Patches:
> User: avg: 0.198  stddev: 0.003  med: 0.197
> Real: avg: 0.201  stddev: 0.003  med: 0.200

question is, is this slower than the variant with is_mpeg12 hardcoded ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080414/873dcce0/attachment.pgp>