[FFmpeg-devel] BFI video decoder

[Michael Niedermayer]

On Fri, Apr 18, 2008 at 03:01:25AM +0530, Sisir Koppaka wrote:
> Patch attached (docs + code)
> Couple of issues left:
> 1. extradata_size check: what do we do if we find it's larger than data[1],
> av_log+return -1? 

yes


> Also, what is size of data[1]?

for PIX_FMT_PAL8 the maximum size a palette can have.


> 2. This warning appears :
> 
> bfi.c: In function 'bfi_decode_frame':
> bfi.c:92: warning: 'offset' may be used uninitialized in this function

ignore it


[...]
> +    uint8_t *src, *dst_offset, *frame_end = bfi->dst + avctx->width * avctx->height, colour1, colour2;
[...]
> +        unsigned int byte = *buf++, code = byte >> 6, length = byte & ~0xC0, offset;

These would be more readable if they where not on a single line.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080417/f6a1f695/attachment.pgp>