[FFmpeg-devel] [PATCH] Incorrect ASF duration

[Michael Niedermayer]

On Fri, Apr 18, 2008 at 01:05:52AM +0200, Henrik Gulbrandsen wrote:
> This is similar to the Ogg problem. The stream duration is not identical
> to the PTS of the last packet if the packet duration is non-negligible.
> 
> The attached examples show the result of
> 
>     ffmpeg -i video.mp4 -vcodec wmv2 -f asf video.wmv
>     ffplay -stats video.wmv > report.txt 2>&1
> 
> before and after the patch. As before, video.mp4 is exactly 24 seconds
> long, at 10 fps. Notice the "Duration: 00:00:23.90" for stats given with
> the current code base!

This shows that there is likely a bug in the asf demuxer or asf muxer,
what makes you belive it is the muxer that needs correction.
What i see is a 50% chance of fixing a bug and a 50% chance of introducing
a new bug instead.
I suggest you use some "official" asf encoder and encode a video of known
length and then check what is written in the file.

Also i suspect that the regression test checksums will change by such
a change to the muxer thus would need to be updated by your patch.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080418/5bf93221/attachment.pgp>