[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Michael Niedermayer]

On Mon, Apr 21, 2008 at 11:44:06AM +1000, Anuradha Suraparaju wrote:
> 
> On Fri, 2008-04-18 at 01:12 +0200, Diego Biurrun wrote:
> 
> [...]
> 
> > > @@ -1614,20 +1618,21 @@
> > >  
> > >  # these are off by default, so fail if requested and not available
> > > -enabled avisynth   && require2 vfw32 "windows.h vfw.h" AVIFileInit -lvfw32
> > > -enabled liba52     && require  liba52 a52dec/a52.h a52_init -la52
> > > -enabled libamr_nb  && require  libamrnb amrnb/interf_dec.h Speech_Decode_Frame_init -lamrnb -lm
> > > -enabled libamr_wb  && require  libamrwb amrwb/dec_if.h D_IF_init -lamrwb -lm
> > > -enabled libfaac    && require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
> > > -enabled libfaad    && require2 libfaad faad.h faacDecOpen -lfaad
> > > -enabled libgsm     && require  libgsm gsm.h gsm_create -lgsm
> > > -enabled libmp3lame && require  LAME lame/lame.h lame_init -lmp3lame -lm
> > > -enabled libnut     && require  libnut libnut.h nut_demuxer_init -lnut
> > > -enabled libtheora  && require  libtheora theora/theora.h theora_info_init -ltheora -logg
> > > -enabled libvorbis  && require  libvorbis vorbis/vorbisenc.h vorbis_info_init -lvorbisenc -lvorbis -logg
> > > -enabled libx264    && require  x264 x264.h x264_encoder_open -lx264 -lm
> > > -enabled libxvid    && require  Xvid xvid.h xvid_global -lxvidcore
> > > -enabled mlib       && require  mediaLib mlib_types.h mlib_VectorSub_S16_U8_Mod -lmlib
> > > +enabled avisynth        && require2 vfw32 "windows.h vfw.h" AVIFileInit -lvfw32
> > > +enabled liba52          && require  liba52 a52dec/a52.h a52_init -la52
> > > +enabled libamr_nb       && require  libamrnb amrnb/interf_dec.h Speech_Decode_Frame_init -lamrnb -lm
> > > +enabled libamr_wb       && require  libamrwb amrwb/dec_if.h D_IF_init -lamrwb -lm
> > > +enabled libfaac         && require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
> > > +enabled libfaad         && require2 libfaad faad.h faacDecOpen -lfaad
> > > +enabled libgsm          && require  libgsm gsm.h gsm_create -lgsm
> > > +enabled libmp3lame      && require  LAME lame/lame.h lame_init -lmp3lame -lm
> > > +enabled libnut          && require  libnut libnut.h nut_demuxer_init -lnut
> > > +enabled libschroedinger && add_extralibs `pkg-config --libs schroedinger-1.0` && extraincs="$extraincs `pkg-config --cflags schroedinger-1.0`" 
> > > +enabled libtheora       && require  libtheora theora/theora.h theora_info_init -ltheora -logg
> > > +enabled libvorbis       && require  libvorbis vorbis/vorbisenc.h vorbis_info_init -lvorbisenc -lvorbis -logg
> > > +enabled libx264         && require  x264 x264.h x264_encoder_open -lx264 -lm
> > > +enabled libxvid         && require  Xvid xvid.h xvid_global -lxvidcore
> > > +enabled mlib            && require  mediaLib mlib_types.h mlib_VectorSub_S16_U8_Mod -lmlib
> > 
> > cosmetics
> 
> Sorry, can you make it clear please. I aligned the columns as requested
> earlier.

Indeed diegos requests are contradictionary if taken literally.
One cannot use "libschroedinger" instead of "schro", 
keep the vertical alignment and
avoid cosmetics (whitespace only changes in the otherwise unchanged lines)

One could ignore the alignment and fix it in a seperate (cosmetics only) patch
afterward.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080421/9d334d08/attachment.pgp>