[FFmpeg-devel] [PATCH] Set AVCodecContext qdiff constraints to 1..31

[Stefano Sabatini]

On date Monday 2008-04-21 11:10:26 -0400, Alexander Strange encoded:
>
> On Apr 21, 2008, at 9:34 AM, Stefano Sabatini wrote:
>
>> Hi, as in subject,
>>
>> I wonder if there is currently a reason for which the AVCodecContext
>> options array constraints for qdiff (INT_MIN..INT_MAX) are different
>> from those of ffmpeg.c:opt_qdiff (1..31).
>>
>> If not I propose to apply this patch.
>>
>> Best regards.
>> -- FFmpeg =  Foolish & Furious MultiPurpose EnGine
>
> Not all codecs have qp1-31. H264 has 0-51 and I'd expect some others  
> (maybe snow?) to have a lot more as well.
> Of course, there's no good reason to set it higher than 5 even in h264, 
> but it might as well have the same min/max as vqscale.

So is it correct to assume that ffmpeg.c:opt_qdiff is wrong instead?

(No I don't want to fix that, I would like to simply delete opt_qdiff
and let qdiff to be managed only by AVOption, but there are other bugs
in AVOption itself to be fixed before...).

Regards.
-- 
FFmpeg =  Fucking and Fucked MultiPurpose EnGraver

Mmh... sorry it's getting more and more impolite each time ;-)...