[FFmpeg-devel] [PATCH] Add supported_samplerates field to AVCodec

[Michael Niedermayer]

On Mon, Apr 21, 2008 at 05:51:25PM +0200, Stefano Sabatini wrote:
> On date Monday 2008-04-21 16:56:42 +0200, Michael Niedermayer encoded:
> > On Mon, Apr 21, 2008 at 12:27:08AM +0200, Stefano Sabatini wrote:
> > > Hi,
> > > 
> > > as suggested in this thread:
> > > http://thread.gmane.org/20080407143527.GA15487 at geppetto
> > > 
> > > I'm not sure what is better if "supported_framerates" (more consistent
> > > with AVCodec.supported_framerates) or "supported_frame_rates" (more
> > > consistent with AVFrame.sample_rate).
> [...]
> > > Index: libavcodec/avcodec.h
> > > ===================================================================
> > > --- libavcodec/avcodec.h	(revision 12912)
> > > +++ libavcodec/avcodec.h	(working copy)
> > > @@ -30,7 +30,7 @@
> > >  #include "libavutil/avutil.h"
> > >  
> > >  #define LIBAVCODEC_VERSION_MAJOR 51
> > > -#define LIBAVCODEC_VERSION_MINOR 55
> > > +#define LIBAVCODEC_VERSION_MINOR 56
> > >  #define LIBAVCODEC_VERSION_MICRO  0
> > >  
> > >  #define LIBAVCODEC_VERSION_INT  AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
> > > @@ -2241,6 +2241,7 @@
> > >      const AVRational *supported_framerates; ///< array of supported framerates, or NULL if any, array is terminated by {0,0}
> > >      const enum PixelFormat *pix_fmts;       ///< array of supported pixel formats, or NULL if unknown, array is terminated by -1
> > >      const char *long_name;                  ///< descriptive name for the codec, meant to be more human readable than \p name
> > 
> > > +    const int *supported_samplerates;       ///< array of supported audio samplerates, or NULL if unknown, array is terminated by -1
> > 
> > i would prefer if the array where terminated by 0
> 
> I don't like this solution, in this way we can't distinguish if a
> codec doesn't support a certain value or if we don't know or we don't
> want to specify the valid values.
> 
> For example suppose we define a common function which checks if the
> provided value for the samplerate is valid looking at the
> supported_samplerates value, if it is set to NULL then the check is
> skipped and will be eventually executed in the open_codec function,
> while if the value is set to -1 (empty list of valid values) then it
> will always fail.

Learn C, especially the difference between pointer and pointed to value.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080421/7bd3235e/attachment.pgp>