[FFmpeg-devel] [RFC] be more kind with wrong psm in mpeg ps

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:

> M?ns Rullg?rd wrote:
>> Baptiste Coudurier wrote:
>>> Baptiste Coudurier wrote:
>>>> Hi,
>>>>
>>>> M?ns Rullg?rd wrote:
>>>>> Michael Niedermayer wrote:
>>>>>> On Mon, Apr 07, 2008 at 04:36:41PM +0200, Baptiste Coudurier wrote:
>>>>>>> M?ns Rullg?rd wrote:
>>>>>>>> Baptiste Coudurier wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Attached patch make ps demuxer correctly detects lpcm files
>>>>>>>>> with wrong psm (mplayer and vlc plays them correctly).
>>>>>>>>>
>>>>>>>>> Should fix wrong_psm_lpcm.mpg on mplayerhq.
>>>>>>>>>
>>>>>>>>> I think those checks are reasonable. Comments ?
>>>>>>>> I don't like it.  It can break valid files.

[...]

>>> Ping
>> 
>> I still don't like it.  Idiots that create invalid files can blame
>> themselves.
>> 
>
> While I understand your point, the point here is more about general
> policy, and general policy is to support as many files as we can without
> breaking and polluting too much the code.

The point is that we'd be adding support for invalid files while
breaking support for some valid files.  That is not acceptable.

If you can find a way to detect the invalid files without affecting
valid ones, I'll consider it.

-- 
M?ns Rullg?rd
mans at mansr.com