[FFmpeg-devel] [PATCH] Ogg Theora granules confused by spec

[Henrik Gulbrandsen]

On Sun, 2008-04-20 at 08:58 +0200, Henrik Gulbrandsen wrote:
> On Fri, 2008-04-18 at 09:55 +0200, Diego Biurrun wrote:
> > On Fri, Apr 18, 2008 at 12:37:45AM -0700, Baptiste Coudurier wrote:
> > > 
> > > Henrik Gulbrandsen wrote:
[...]
> > > > I doubt the intention of its author was to turn the third part of the version
> > > > field (the version revision) into a generic flag field for the future.
> > > 
> > > IMHO specs writers must really take care and think before writing such 
> > > statements.
> > 
> > There is a better solution IMO: Get in contact with the spec writers and
> > ask them to clarify the spec.
> > 
> > Diego
> 
> Good idea!
> 
> I've sent an email, so we'll see what the next spec version says.

A statement from the guy responsible for this particular section of the
Theora specification follows:

On Sun, 2008-04-20 at 15:41 -0700, Ralph Giles wrote:
> No, the tiny revision number isn't a flag. We changed the granulepos  
> definition and bumped the revision number to indicate the change, but  
> that's all. The intent was just that old streams could be handled  
> correctly based on their version number; we expect later revisions to  
> have the same granulepos scheme as 3.2.1 streams.
> 
> VREV signals optional features that are generally compatible with the  
> major and minor revision numbers. Since the granulepos is only a off- 
> by-one, usually in the more forgiving direction, we thought it was  
> reasonable to treat it as backward-compatible.

I guess this means that the original patch is reasonable. It doesn't
influence regression tests (or anything else, actually), so I simply
attach it again, without any real updates.

/Henrik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora_vrev.patch
Type: text/x-patch
Size: 1718 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080422/e9e7a51f/attachment.bin>