[FFmpeg-devel] [PATCH]Add Dirac support to ffmpeg via libdirac_* and Schroedinger libraries]

[Diego Biurrun]

On Wed, Apr 23, 2008 at 02:09:53PM +1000, Anuradha Suraparaju wrote:
> 
> On Tue, 2008-04-22 at 19:49 +0200, Diego Biurrun wrote:
> > On Tue, Apr 22, 2008 at 07:12:05PM +0200, Diego Biurrun wrote:
> > > On Thu, Apr 17, 2008 at 09:15:51PM +1000, Anuradha Suraparaju wrote:
> > > > 
> > > > I've attached the dirac patch to this email. I've created the patch
> > > > using the latest svn version 12879.
> > > > --- ffmpegsvn_trunk/configure	2008-04-17 11:14:38.000000000 +1000
> > > > +++ ffmpegsvn_trunk_dirac/configure	2008-04-17 20:43:10.000000000 +1000
> > > > @@ -2014,6 +2021,7 @@
> > > >  fi
> > > >  echo "LIB_INSTALL_EXTRA_CMD=${LIB_INSTALL_EXTRA_CMD}" >> config.mak
> > > >  echo "EXTRALIBS=$extralibs" >> config.mak
> > > > +echo "EXTRAINCS=$extraincs" >> config.mak
> > >  
> > > I maintain that this is unnecessary.  Just..
> > > 
> > > > --- ffmpegsvn_trunk/libavcodec/libdiracdec.c	1970-01-01 10:00:00.000000000 +1000
> > > > +++ ffmpegsvn_trunk_dirac/libavcodec/libdiracdec.c	2008-04-17 16:26:59.000000000 +1000
> > > > @@ -0,0 +1,211 @@
> > > > +
> > > > +#include <libdirac_decoder/dirac_parser.h>
> > > 
> > > .. prefix this with dirac/.
> > 
> > Of course this will not work, since the headers in libdirac_decoder/
> > etc. #include other headers from that directory.
> > 
> 
> The same applies for Schroedinger header files as well. I can't figure
> out how this can be done other than by adding extra functions to
> configure. Can you suggest a method?

add_cflags

Even better: You could restructure your includes to be less weird.  I
have never seen empty subdirectories below /usr/[local/]include and I
must say I find it very weird.  You are behaving different from any
library I have seen before or is installed on my system.

Diego