[FFmpeg-devel] [PATCH] Common ACELP routines (3/3) - LPC decoding routines

[Michael Niedermayer]

On Wed, Apr 23, 2008 at 09:44:25PM +0100, Robert Swain wrote:
> On 23 Apr 2008, at 20:53, Vladimir Voroshilov wrote:
[...]
> >>> + * \param lsp [out] (Q15) LSP coefficients (-1 <= lsp < 1)
> >>> + *
> >>> + * \remark It is safe to pass the same array in lsf and lsp  
> >>> parameters
> >>> + */
> >>> +void ff_acelp_lsf2lsp(const int16_t *lsf, int16_t *lsp, int16_t  
> >>> factor)
> >>
> >> i slightly prefer that the written to argument is left (lsp, lsf,  
> >> factor)
> >> same for the other functions (this of course is minor nitpicking ...)
> >
> > ok. Remaining fixes of ordering will be made while touching code.
> 
> I prefer them ordered with inputs on the left and outputs on the  
> right, but it's a matter of taste and wouldn't matter too much if they  
> were randomly ordered.

Randomly ordered is the worst, it should be consistant at least.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080423/602911a6/attachment.pgp>