[FFmpeg-devel] [RFC] be more kind with wrong psm in mpeg ps

[Baptiste Coudurier]

Baptiste Coudurier wrote:
> M?ns Rullg?rd wrote:
>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>>
>>> M?ns Rullg?rd wrote:
>>>> Baptiste Coudurier wrote:
>>>>> Baptiste Coudurier wrote:
>>>>>> Hi,
>>>>>>
>>>>>> M?ns Rullg?rd wrote:
>>>>>>> Michael Niedermayer wrote:
>>>>>>>> On Mon, Apr 07, 2008 at 04:36:41PM +0200, Baptiste Coudurier wrote:
>>>>>>>>> M?ns Rullg?rd wrote:
>>>>>>>>>> Baptiste Coudurier wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Attached patch make ps demuxer correctly detects lpcm files
>>>>>>>>>>> with wrong psm (mplayer and vlc plays them correctly).
>>>>>>>>>>>
>>>>>>>>>>> Should fix wrong_psm_lpcm.mpg on mplayerhq.
>>>>>>>>>>>
>>>>>>>>>>> I think those checks are reasonable. Comments ?
>>>>>>>>>> I don't like it.  It can break valid files.
>> [...]
>>
>>>>> Ping
>>>> I still don't like it.  Idiots that create invalid files can blame
>>>> themselves.
>>>>
>>> While I understand your point, the point here is more about general
>>> policy, and general policy is to support as many files as we can without
>>> breaking and polluting too much the code.
>> The point is that we'd be adding support for invalid files while
>> breaking support for some valid files.  That is not acceptable.
> 
> It could break when using private_stream_1, psm mentioning mpeg1 audio,
> and not using DVD(?) private mechanism, but IMHO you must really brain
> dead doing that, even more than using pcm and wanting to use a psm (psm
> for pcm is not defined AFAIK).
> 
> Atm I don't see how this patch can break valid files.
> 

Ping :>

So, is it possible to find a reasonable compromise with details of what
this could break ?

Thanks everyone.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG SAS                                     http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312