[FFmpeg-devel] [Ffmpeg-devel] [PATCH] GSM-MS decoder and encoder

[Baptiste Coudurier]

Hi,

Michel Bardiaux wrote:
> Baptiste Coudurier wrote:
>> Michel Bardiaux wrote:
>>> Baptiste Coudurier wrote:
>>>> Hi,
>>>>
>>>> Michel Bardiaux wrote:
>>>>> Baptiste Coudurier wrote:
>>>>>> Michel Bardiaux wrote:
>>>>> [time for a big snip]
>>>>>>> Michael has reported 13200 in aiff, do you also see 13200 for mov? Then 
>>>>>>> accepting (OK, silently) 0, 13000 and 13200 when decoding solves your 
>>>>>>> problem while leaving some safety.
>>>>>> Yes.
>>>>> OK then, my proposition is that on decoding, all 3 are accepted 
>>>>> silently, anything else causes a warning (but is accepted); on encoding, 
>>>>> anything else than 13000 elicits a warning and is forced to 13000.
>>> Ok with this spec, or is it necessary to tolerate 13200 on encoding too 
>>> because some muxer sets 13200 before init is called?
>> Well you can check in the code, that is mov and aiff, I guess.
> 
> You wrote in another thread (in reply to my proposal to make checks 
> dependednt on strictness):
>  > Yes, and now I'd like your check being done when stricness is explicitly
>  > asked :>
>  >
> 
> That modifies things:
> Default: encoding: silently accepts 13200. I still think a warning for 
> other values would be good.
> Strict: encoding: anything else than 13000 and *maybe* 13200 rejected.
> 	For 13200, I still have to see in mov and aiff.
> Default: decoding: accepts anything silently.
> Strict: decoding: reject others than 13000 13200.
> 
> Greetings,

Can we please fix this ?
http://samples.mplayerhq.hu/A-codecs/GSM/sample-gsm-8000.mov

Choose whichever solution you prefer, but this sample should play
without error message :>

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312