[FFmpeg-devel] [PATCH] pthread detection on mingw + static pthread

[Måns Rullgård]

Ramiro Polla wrote:
> Hello,
>
>>> Or even better:
>>> gcc -o tmp.exe tmp.o -lpthreadGC2 -lx264 -lpthreadGC2
>>>                       ^^ FFmpeg ^^        ^^  x264  ^^
>> This obviously has nothing to do with x264.h detection
>
> It has to do with x264 detection. The thing about the header is that
> once you compile a program that includes x264.h, you must have already
> included stdint.h before. In require() it checks the header and the lib
> independently

Exactly, so there is no need to pull in stdint.h.

> (why not just make a real compilation+link check for all?).

To avoid whatever strange requirements lib headers might have.  Additional
headers are only the beginning.  Sometimes headers might require other
things as well.

> In require2(), it includes <x264.h>, so stdint.h must be added.

But we're not using require2.

> In configure there is:
> # check for some common methods of building with pthread support
> # do this before the optional library checks as some of them require
> pthreads
>
> My last suggestion was to add the pthreads flag to FFmpeg, and then try
> x264 with and without the pthreads flag.

Yes, there is a problem here, and I'll fix it, hopefully tonight.

-- 
M?ns Rullg?rd
mans at mansr.com