[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

[Stefano Sabatini]

On date Friday 2008-04-25 19:11:26 -0400, Alexander Strange encoded:

Hi,
 
> On Apr 25, 2008, at 6:24 PM, Stefano Sabatini wrote:
> 
> > Hi all,
> >
> > it has been a long and boring afternoon, I tried to choose the names
> > following as close as possible the indications in each file, reverting
> > to the multimedia wiki/wikipedia when that information seemed too
> > scarce.
> >
> > I know maybe I didn't the better possible choices, for this reason I
> > would like every codec maintainer to review this patch and amend the
> > long_name I choosed for their codecs.
> >
> > Also note that I left out some files (namely adpcm.c, libfaad.c,  
> > pcm.c)
> > because they require the modification of the macros used to create the
> > various codecs, which I'm leaving for another patch.
> >
> > Best regards.
> > -- 
> > FFmpeg = Fucking Fast MultiPurpose EnGraver
> > <add-missing-long-names-00.patch>
> 
> > +    .long_name = "Autodesc RLE",
> 
> Autodesk, I think
> 
> > +    .long_name = "ATSC A/52 / AC-3 (Adaptive Transform Codec 3)",
> 
> Isn't that a bit too long? Do we care what AC-3 stands for?
> 
> > +    .long_name = "Monkey\'s Audio lossless audio",
> 
> No need to escape '.
> 
> > +    .long_name = "COOK compatible",
> > +    .long_name = "DCA (DTS Coherent Acoustics) Compatible",
> 
> compatible?

Removed "compatible" here and everywhere.
 
> > +    .long_name = "FLAC (Free Lossless Audio Codec",
> 
> Missing ).
> 
> > +    .long_name = "FFVHuff",
> 
> I'm not sure that's how it's capitalized, but i might be wrong.

FFVhuff?

Also can someone suggest a more meaningful long name?
 
> > +    .long_name = "Karl Morton\'s Video Codec",
> 
> ' again.
> 
> > +    .long_name= "libmp3lame MP3 (MPEG audio layer 3)",
> 
> I don't see any reason to put "lib" in all the library names. They're  
> called LAME and x264.

Mmmh... I prefer the prefix for consistency furthermore the
abovementioned codecs are library interfaces, so IMHO they should
explicitly refer to the library used (no strong opinion on this, so if
you or other insist then I'll change it).

Addressed all the other comments, also I added some missing long_names
and fixed some wrong ones.

Best regards.
-- 
FFmpeg = Friendly & Frenzy MultiPurpose EnGine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-missing-long-names-01.patch
Type: text/x-diff
Size: 62265 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080426/db6668dc/attachment.patch>