[FFmpeg-devel] [PATCH] mp3on4 heavy cleanup

[Baptiste Coudurier]

Hi Reimar,

Reimar D?ffinger wrote:
> [...]
> 
>> +        fsize = FFMIN(fsize, FFMIN(len, MPA_MAX_CODED_FRAME_SIZE));
> 
> Create a FFMIN3 just like the FFMAX3 IMO.

Good idea, done.

>> [...]
>>
>>  /* Next 3 arrays are indexed by channel config number (passed via codecdata) */
>> -static int mp3Frames[16] = {0,1,1,2,3,3,4,5,2};   /* number of mp3 decoder instances */
>> -static int mp3Channels[16] = {0,1,2,3,4,5,6,8,4}; /* total output channels */
>> +static const uint8_t mp3_frames[8] = {0,1,1,2,3,3,4,5}; /* number of mp3 decoder instances */
>>  /* offsets into output buffer, assume output order is FL FR BL BR C LFE */
>> -static int chan_offset[9][5] = {
>> +static const uint8_t chan_offset[9][5] = {
> 
> That should probably be applied separately. IMO you do not need to send
> a patch for such things.

Ok, applied.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312