[FFmpeg-devel] [PATCH] Fill unspecified AVCodec long_name fields

[Diego Biurrun]

On Mon, Apr 28, 2008 at 09:08:54AM +0200, Stefano Sabatini wrote:
> On date Monday 2008-04-28 00:40:32 +0200, Diego Biurrun encoded:
> > 
> > Next bunch applied, could you please update again?
> 
> Yes, new patch attached.

Another part applied, comments below.

> --- libavcodec/bmp.c	(revision 13009)
> +++ libavcodec/bmp.c	(working copy)
> @@ -257,5 +257,6 @@
>      bmp_decode_end,
> -    bmp_decode_frame
> +    bmp_decode_frame,
> +    .long_name = "BMP image",

Hmmmm

> --- libavcodec/dv.c	(revision 13009)
> +++ libavcodec/dv.c	(working copy)
> @@ -1240,6 +1240,7 @@
>      .pix_fmts = (enum PixelFormat[]) {PIX_FMT_YUV411P, PIX_FMT_YUV422P, PIX_FMT_YUV420P, -1},
> +    .long_name = "DV",

I think DV is the short form of "Digital Video".

> --- libavcodec/flicvideo.c	(revision 13009)
> +++ libavcodec/flicvideo.c	(working copy)
> @@ -749,5 +749,6 @@
> -    NULL
> +    NULL,
> +    .long_name = "Autodesk Animator Flic (.fli/.flc) video",

I would say leave out the filename extensions, same below.

> --- libavcodec/h263dec.c	(revision 13009)
> +++ libavcodec/h263dec.c	(working copy)
> @@ -748,6 +750,7 @@
>      CODEC_CAP_DRAW_HORIZ_BAND | CODEC_CAP_DR1,
> +    .long_name="Microsoft variant version 1 MPEG-4 part 2",

Is this some sort of official name?  Otherwise I would say
"MPEG-4 part 2 Microsoft variant version 1".

> --- libavcodec/h264.c	(revision 13009)
> +++ libavcodec/h264.c	(working copy)
> @@ -8087,6 +8087,7 @@
>      .flush= flush_dpb,
> +    .long_name = "H.264 / AVC / MPEG-4 part 10",

I think it is MPEG-4 AVC.

> --- libavcodec/huffyuv.c	(revision 13009)
> +++ libavcodec/huffyuv.c	(working copy)
> @@ -1444,7 +1444,8 @@
> -    NULL
> +    NULL,
> +    .long_name = "Huffyuv",

The multimedia wiki calls this HuffYUV :)

> --- libavcodec/libgsm.c	(revision 13009)
> +++ libavcodec/libgsm.c	(working copy)
> @@ -106,6 +106,7 @@
>      libgsm_close,
> +    .long_name = "libgsm GSM (Global System for Mobile Communications)",

I would leave out the explanation in parentheses.

> --- libavcodec/libx264.c	(revision 13009)
> +++ libavcodec/libx264.c	(working copy)
> @@ -296,5 +296,6 @@
> -    .pix_fmts = (enum PixelFormat[]) { PIX_FMT_YUV420P, -1 }
> +    .pix_fmts = (enum PixelFormat[]) { PIX_FMT_YUV420P, -1 },
> +    .long_name = "libx264 H.264 / AVC / MPEG-4 part 10",

see above

> --- libavcodec/libxvidff.c	(revision 13009)
> +++ libavcodec/libxvidff.c	(working copy)
> @@ -774,4 +774,5 @@
>      .pix_fmts= (enum PixelFormat[]){PIX_FMT_YUV420P, -1},
> +    .long_name= "libxvidcore MPEG-4 part 2",

Maybe add MPEG-4 ASP here as well?

> --- libavcodec/ljpegenc.c	(revision 13009)
> +++ libavcodec/ljpegenc.c	(working copy)
> @@ -194,4 +194,5 @@
>      MPV_encode_end,
> +    .long_name = "Lossless JPEG",

lossless

> --- libavcodec/mjpegbdec.c	(revision 13009)
> +++ libavcodec/mjpegbdec.c	(working copy)
> @@ -145,5 +145,6 @@
> +    NULL,
> +    .long_name = "Apple MJPEG-B",

This is Apple-specific?

> --- libavcodec/mpeg12.c	(revision 13009)
> +++ libavcodec/mpeg12.c	(working copy)
> @@ -2442,6 +2442,7 @@
>      .flush= ff_mpeg_flush,
> +    .long_name= "MPEG-1 video",

I would say s/video//, same below.

> --- libavcodec/mpegvideo_enc.c	(revision 13009)
> +++ libavcodec/mpegvideo_enc.c	(working copy)
> @@ -3800,6 +3805,7 @@
>      .capabilities= CODEC_CAP_DELAY,
> +    .long_name= "MPEG-4 part 2",
> @@ -3811,6 +3817,7 @@
>      .pix_fmts= (enum PixelFormat[]){PIX_FMT_YUV420P, -1},
> +    .long_name= "Microsoft variant version 1 MPEG-4 part 2",
> @@ -3822,6 +3829,7 @@
>      .pix_fmts= (enum PixelFormat[]){PIX_FMT_YUV420P, -1},
> +    .long_name= "Microsoft variant version 2 MPEG-4 part 2",
> @@ -3833,6 +3841,7 @@
>      .pix_fmts= (enum PixelFormat[]){PIX_FMT_YUV420P, -1},
> +    .long_name= "Microsoft variant version 3 MPEG-4 part 2",

see above

> --- libavcodec/msrle.c	(revision 13009)
> +++ libavcodec/msrle.c	(working copy)
> @@ -304,4 +304,5 @@
>      CODEC_CAP_DR1,
> +    .long_name= "Microsoft RLE Video",

I would say s/video//.

> --- libavcodec/sonic.c	(revision 13009)
> +++ libavcodec/sonic.c	(working copy)
> @@ -957,6 +958,7 @@
>      NULL,
> +    .long_name = "Sonic Lossless",

lossless

> --- libavcodec/tiertexseqv.c	(revision 13009)
> +++ libavcodec/tiertexseqv.c	(working copy)
> @@ -227,4 +227,5 @@
>      CODEC_CAP_DR1,
> +    .long_name = "Tiertex Limited SEQ Video",

Hmm, the multimedia wiki lists this as simply "SEQ".

> --- libavcodec/truemotion1.c	(revision 13009)
> +++ libavcodec/truemotion1.c	(working copy)
> @@ -899,4 +899,5 @@
>      CODEC_CAP_DR1,
> +    .long_name = "Duck TrueMotion 1.0",
> --- libavcodec/truemotion2.c	(revision 13009)
> +++ libavcodec/truemotion2.c	(working copy)
> @@ -887,4 +887,5 @@
>      CODEC_CAP_DR1,
> +    .long_name = "Duck/On2 TrueMotion 2.0",

Duck or Duck/On2?

> --- libavcodec/tta.c	(revision 13009)
> +++ libavcodec/tta.c	(working copy)
> @@ -443,4 +443,5 @@
>      tta_decode_frame,
> +    .long_name = "TTA (The Lossless True Audio)",

I think this is just "True Audio".

> --- libavcodec/vmnc.c	(revision 13009)
> +++ libavcodec/vmnc.c	(working copy)
> @@ -517,6 +517,7 @@
>      decode_end,
> -    decode_frame
> +    decode_frame,
> +    .long_name = "VMware Screen Codec",

The multimedia Wiki calls this VMware Video.

> --- libavcodec/vqavideo.c	(revision 13009)
> +++ libavcodec/vqavideo.c	(working copy)
> @@ -616,4 +616,5 @@
>      CODEC_CAP_DR1,
> +    .long_name = "Westwood Studios VQA Video",

The multimedia wiki says: "VQA stands for Vector Quantized Animation and
is a FMV format used in a number of computer games by Westwood Studios."

Diego