[FFmpeg-devel] [PATCH] cmdutils.c warning fix

[Diego Biurrun]

On Sun, Aug 03, 2008 at 03:30:27PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 03, 2008 at 01:47:11PM +0200, Diego Biurrun wrote:
> > On Sat, Aug 02, 2008 at 07:23:19PM +0200, Michael Niedermayer wrote:
> > > On Sat, Aug 02, 2008 at 01:27:07PM +0200, Diego Biurrun wrote:
> > > > Here is a small one to get rid of
> > > > 
> > > > cmdutils.c:226: warning: 'avcodec_build' is deprecated (declared at ./libavcodec/avcodec.h:2534)
> > > 
> > > the patch is incorrect, and ive alraedy rejected it when (IIRC) stefano 
> > > proposed it.
> > > avcodec_build() is the version of the linked library, LIBAVCODEC_BUILD is
> > > the version of the headers.
> > 
> > Why is this wrong for libavcodec and correct for all other libs in the
> > show_version function?  
> 
> Who said it is correct for the others?
> 
> > And why is it correct for libavcodec in the
> > show_banner function 10 lines above?
> 
> Who said it is correct there?

Nobody said it is correct, but when you have 10 such examples in the
immediate vicinity without a comment indicating that they should be
changed, then it's very easy to misunderstand...

What is the problem with mixing the version of the headers and of the
linked library anyway?  Do I understand correctly that it is for the
case where ffmpeg/ffplay/ffserver is dynamically linked and the version
of the linked libs differs from the version of the headers used to
compile the binary?

And thus ideally there should be a _version() function for every single
library?

> > Anyway, here is a patch using avcodec_version().
> 
> ok

Applied.

Diego