[FFmpeg-devel] [PATCH 1/4] add a generic function to lavc to log messages about missing features.

[Justin Ruggles]

Justin Ruggles wrote:
> Michael Niedermayer wrote:
>> On Sat, Jul 19, 2008 at 08:31:52PM -0400, Justin Ruggles wrote:
>>> Michael Niedermayer wrote:
>> [...]
>>
>>
>>> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
>>> index 3f1b4ea..54a6672 100644
>>> --- a/libavcodec/utils.c
>>> +++ b/libavcodec/utils.c
>>> @@ -1488,3 +1488,15 @@ int av_parse_video_frame_rate(AVRational *frame_rate, const char *arg)
>>>      else
>>>          return 0;
>>>  }
>>> +
>>> +void av_log_missing_feature(void *avc, const char *feature, int want_sample)
>>> +{
>>> +    av_log(avc, AV_LOG_WARNING, "%s not implemented. If you want to help, "
>>> +            "update your FFmpeg version to the newest one from SVN. If the "
>>> +            "problem still occurs, it means that your file has an extension "
>>> +            "which has not been implemented.", feature);
>>> +    if(want_sample)
>>> +        av_log(avc, AV_LOG_WARNING, " Upload a sample of the audio from this "
>>> +                "file to ftp://upload.mplayerhq.hu/incoming and contact the "
>>> +                "ffmpeg-devel mailing list.");
>>> +}
>> you are missing \n in these
> 
> fixed.
> 
>> besides the text sounds strange
>>
>> i mean:
>>             "X not implemented. If you want to help,"
>>             "update your FFmpeg version to the newest one from SVN. If the "
>>             "problem still occurs, it means that your file has an extension "
>>             "which has not been implemented."
>>
>> the "If you want to help" makes no sense if the second part is not printed.
> 
> fixed.
> 
> new patch attached.

I just noticed that the ftp path is wrong.  I'm used to logging in as a
developer...

newer patch attached.

-Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_log_missing_feature.diff
Type: text/x-patch
Size: 1904 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080803/e76404ac/attachment.bin>