[FFmpeg-devel] [PATCH] mlpdec: Move quant_step_size out of substream context.

[Michael Niedermayer]

On Tue, Aug 12, 2008 at 06:24:14PM -0300, Ramiro Polla wrote:
> Hello,
> 
> Since I don't have any specs for MLP, it's hard to know if this change
> will introduce any regression. Probably not, since the current code
> already has a similar limitation.
> 
> quant_step_size is currently defined for every channel for every
> substream. I guess that all variables related to audio channels (not
> matrix channels) should be the same for all substreams. So we could
> save by having the channel information on a separate struct.
> 
> I have tested this with all my samples. Whenever two different streams
> write quant_step_size to the same channel, it has always been the same
> value. Furthermore, the code already has only enough space for each
> channel (and not channel * substream) for sign_huff_offset, which is
> updated whenever quant_step_size is read.

Is this useful or needed for your encoder? if not then iam slightly
against it.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/3c44ef12/attachment.pgp>