[FFmpeg-devel] [PATCH] Initialize crc data in mlp_parser.c in its own function.

[Ramiro Polla]

Hi,

On Tue, Aug 12, 2008 at 11:35 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Aug 12, 2008 at 11:17:00PM -0300, Ramiro Polla wrote:
>> Hello,
>>
>> Attached patch initializes crc data from mlp_parser.c in its own function.
>>
>> This removes the if (!crc_init) out of every call to mlp_checksum16().
>> It will also help in sharing the crc data between encoder and decoder.
>
> ok

Applied.

>> One thing though. The parser uses crc_2d, the decoder uses crc_1d and
>> crc_63, and the encoder uses all three. Is it ok to assume that the
>> decoder will need the parser, and that the parser will be used for the
>> decoder, and hence make both (parser and decoder) call an
>> ff_mlp_init_crc() function that initializes all three crc structs?
>> That way it's easier to share the same init function with the encoder.
>
> its ok to have shared functions with proper dependancies in the makefile
> its not ok to assume that there is a parser before the decoder or a
> decoder after the parser

Ok. I'll see what I can do about it...

Ramiro Polla