[FFmpeg-devel] [PATCH] move M_PI to mathematics.h

Aurelien Jacobs aurel
Wed Aug 13 13:10:16 CEST 2008


Reimar Doeffinger wrote:

> On Wed, Aug 13, 2008 at 12:16:47PM +0200, Aurelien Jacobs wrote:
> > I just noticed that M_PI is defined in internal.h while I added other
> > math constants in mathematics.h. Attached patch moves M_PI into
> > mathematics.h.
> > If you prefer me to move all consts to internal.h, just say so.
> 
> I'd prefer it to be in mathematics.h, since that is an installed header
> it could be used for MPlayer, too, if we ever want it.
> But mathematics.h being an installed header also means these changes should
> bump the version number IMO.

I agree about this, and will commit with minor version bump, if no one
disagree.

Aurel




More information about the ffmpeg-devel mailing list