[FFmpeg-devel] [PATCH] Encapsulate Dirac in MPEG TS.

[Anuradha Suraparaju]

On Wed, 2008-08-13 at 04:28 +0200, Michael Niedermayer wrote:
> On Wed, Aug 13, 2008 at 03:02:33AM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Wed, Aug 13, 2008 at 01:26:53AM +0100, M?ns Rullg?rd wrote:
> > >> Diego Biurrun <diego at biurrun.de> writes:
> > >> 
> > >> > On Fri, Jul 18, 2008 at 10:07:50AM +1000, Anuradha Suraparaju wrote:
> > >> >> 
> > >> >> On Thu, 2008-07-17 at 09:44 +0200, Benoit Fouet wrote:
> > >> >> > 
> > >> >> > Anuradha Suraparaju wrote:
> > >> >> > >
> > >> >> > > Resubmitting patch against svn revision 14260 with the recommended
> > >> >> > > changes.
> > >> >> > 
> > >> >> > it seems you forgot to attach the patch
> > >> >> 
> > >> >> Sorry about that. Here it is.
> > >> >
> > >> > Mans, OK to apply?
> > >> 
> > >> I have to say, the patch is quite ugly, although to be fair, the code
> > >> is ugly to begin with.
> > >> 
> > >> Whatever happened to that gsoc project to write a new TS muxer?
> > >
> > > it was highly unfinished at the end of GSOC, baptiste then continued working
> > > on it and the first patch is waiting since several month on a review from
> > > you:
> > 
> > Why me?  It mainly touches the mpegps muxer, which I didn't write, and
> > don't know how it works.  It would be better if someone with a good
> > understanding of that code reviewed it.
> 
> hmm, i thought you maintain the mpegps de + muxer but it seems you are
> not listed in MAINTAINERS for that ...
> 
> ill review that patch.

There has been a modification to the mapping spec. The modified spec is
going to be uploaded soon. I wanted to get the changes in so that they
will be reviewed with the rest of the patch. The main change is that no
Dirac packet shall span multiple PES packets and that each PES packet
containing Dirac data shall commence with a Dirac data unit. I modified
the patch to mpegtsenc.c (rev 14725) accordingly and attached it to this
email.

> Do you mind if i add myself to MAINTAINERS for mpeg-ps muxer? and demuxer?
> 
> [...]
> 

Regards,
Anuradha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegsvn_trunk_revision_14725-dirac_mpegtsenc.diff
Type: text/x-patch
Size: 3452 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/c87b44b7/attachment.bin>