[FFmpeg-devel] [PATCH] Split common code for MLP to mlp.[ch].

[Michael Niedermayer]

SSOn Wed, Aug 13, 2008 at 12:38:07AM -0300, Ramiro Polla wrote:
> Hello,
> 
> Attached patches remove common code from the MLP encoder in the SoC
> repo and the decoder (and the parser) and puts it in common files.
> 
> To commit, the split to mlp.[ch] would be made with svn cp from
> mlpdec.c. I attached them as the resulting file to easy reviewing (or
> is it better to have the diffs to mlpdec.c?).

you could just attach both they are both usefull for reviewing
as is my awnser to the patch is
its ok under the condition that it just moves stuff around (hard to
tell as the new files are not attached as diff)
and that the issue pointed out below is fixed

[...]

> } ChannelParams;
> 
> /** Tables defining the Huffman codes.
>  *  There are three entropy coding methods used in MLP (four if you count
>  *  "none" as a method). These use the same sequences for codes starting with
>  *  00 or 01, but have different codes starting with 1. */
> 
> extern const uint8_t ff_mlp_huffman_tables[3][18][2];

the */ should be on a line of its own so adding more text does not
need to change the previous last line
also there should be more \n above than below, as is the comment is exactly
between 2 things and that looks a little odd. moving the */ wil likely be
enough though when theres no empty line after it..

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/f3955227/attachment.pgp>