[FFmpeg-devel] [PATCH] Split common code for MLP to mlp.[ch].

[Ramiro Polla]

On Wed, Aug 13, 2008 at 10:13 AM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> Hello,
>
> I replied to this e-mail with two sets of big patches and it was too
> big for the ML. I'm sending them again separately.
>
> On Wed, Aug 13, 2008 at 9:38 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> SSOn Wed, Aug 13, 2008 at 12:38:07AM -0300, Ramiro Polla wrote:
>>> Hello,
>>>
>>> Attached patches remove common code from the MLP encoder in the SoC
>>> repo and the decoder (and the parser) and puts it in common files.
>>>
>>> To commit, the split to mlp.[ch] would be made with svn cp from
>>> mlpdec.c. I attached them as the resulting file to easy reviewing (or
>>> is it better to have the diffs to mlpdec.c?).
>>
>> you could just attach both they are both usefull for reviewing
>
> I'm attaching them as diffs again. One for each file, but to be
> committed all at once. What changed is that I removed the duplicate
> comment for both checksum functions in mlp.h. Also I copied with the
> */ in the same line, since that's how it is in mlpdec.
>
> I'll post a followup to this reply with the second set of patches.

And here they are. The difference between the previous ones is that
they have mlp_parse_init call a function in mlp_parser.c which in turn
calls the common function in mlp.c. This way we can avoid #include'ing
avcodec.h in mlp.h. It's attached as mlp_parser_2.c.diff,
mlp_2.c.diff, and mlp_2.h.diff. mlpdec.c.diff is the same as the
previous e-mail.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp_2.c.diff
Type: text/x-diff
Size: 40783 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/9c321e53/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp_2.h.diff
Type: text/x-diff
Size: 40047 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/9c321e53/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlp_parser_2.c.diff
Type: text/x-diff
Size: 1493 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080813/9c321e53/attachment-0002.diff>