[FFmpeg-devel] [VOTE] Multiple inclusion guards in headers

[Diego Biurrun]

On Sun, Aug 17, 2008 at 08:08:06PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 17, 2008 at 06:44:27PM +0100, Robert Swain wrote:
> > 2008/8/17 Michael Niedermayer <michaelni at gmx.at>:
> > > On Sun, Aug 17, 2008 at 06:27:45PM +0100, Robert Swain wrote:
> > >> 2008/8/17 Michael Niedermayer <michaelni at gmx.at>:
> > >> [The beginning of another potential flame war]
> > >>
> > >> Michael, do you really want to have the burden of flame wars on top of
> > >> reviewing code right now? I was hoping nothing would flare up for your
> > >> sake so you didn't feel compelled to deal with such but you seem to
> > >> now be starting it yourself...
> > >
> > > Sorry but if i commit code with a clear notice that it will be cleaned
> > > up ASAP and diego replies with nothing more than
> > > "(sigh)"
> > > then i really think you are now complaining to the wrong person about
> > > starting something
> > 
> > I did not see your notice about cleaning it up ASAP and maybe Diego
> > did not also. But why not clean it up beforehand and then commit it
> > rather than committing it and then cleaning it up. You would expect
> > others to clean their code before committing, would you not?
> 
> I wanted to preserve the history of pca.c/h
> thats why i commited it and then applied various fixes and improvments
> from ramiro and myself seperately

I don't think anything was gained from this.

Diego