[FFmpeg-devel] [VOTE] License header consistency

Måns Rullgård mans
Mon Aug 18 16:02:37 CEST 2008


Ivan Kalvachev wrote:
> On 8/18/08, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Mon, Aug 18, 2008 at 09:05:57AM +0300, Tomi Ollila wrote:
>>> On Mon 18 Aug 2008 08:54, Tomi Ollila <tomi.ollila at guru.guru-group.fi>
>>> writes:
>>>
>>> >
>>> > What kind of pre-commit hook ?
>>> >
>>> > Like this?
>>> >
>>> > --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
>>> heavily buggy version deleted
>>> > --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
>>>
>>> #!/bin/sh
>>>
>>> case `head -n <l1> <f> | tr -d \\015 | sha1sum` in <sum-of-gpl-2.1>*) exit
>>> 0 ;; esac
>>> case `head -n <l2> <f> | tr -d \\015 | sha1sum` in <sum-of-lgpl-2.0>*)
>>> exit 0 ;; esac
>>>
>>> echo "File '<f>' license header mismatch. >&2
>>> exit 1
>>
>> The license headers look like:
>> /*
>>  * copyright (c) 2001 Fabrice Bellard
>>  *
>>  * This file is part of FFmpeg.
>> ...
>> the first line will likely lead to sha1 mismatches
>
> This check would also exclude the possibility of using more permissive
> licenses like BSD, MIT, public code - e.g. vc1dsp_mmc.c

Good point.  We could have a list of allowed licenses, of course.

> I mean, at least without asking roots for help,
> and they like to ignore 99% of the requests.

Where did that come from?  I can't remember you ever requesting anything,
so I can't see how you can possibly have any opinion on this matter.

Attacks like this is a reason I call you a troll, or worse.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list