[FFmpeg-devel] [PATCH] -fs parameter human friendly

[Michael Niedermayer]

On Tue, Aug 19, 2008 at 10:26:59PM -0400, The Wanderer wrote:
> Michael Niedermayer wrote:
> 
> > On Mon, Aug 11, 2008 at 11:43:53PM +0200, Stefano Sabatini wrote:
> 
> >> + * Values are expressed in
> >> + * bits, unless the 'B' postfix is used, in this case the values are
> >> + * assumed to be in bytes.
> > 
> > what?
> 
> I would read this as meaning "if a value does not have the 'B' suffix,
> it is assumed to be expressed in bits; if it does have that suffix, it
> is assumed to be expressed in bytes". The current phrasing seems
> relatively clear to me (even in my current mildly bleary state of mind),
> although I would say "in which case" instead of "in this case".

its not a issue of grammer, its a issue of (av_)strtod parsing a string and
returning a double. Simply try to awnser if "3.141593" is in bits or bytes
according to this description. It simply makes no sense, the number is
not in bits nor in bytes. Nor does either of them have any meaning here


[...]
> >> + * @return the value of the parsed string as a numer of bits
> > 
> > numer!? bits?
> 
> "number", obviously - and I interpret this as meaning that the return
> value will always be expressed in bits, no matter what units the input
> string used for its number.

double pi= av_strtod("3.1415927", NULL); 
is in units of bits?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080820/a8382ee6/attachment.pgp>