[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

[Ronald S. Bultje]

Hi Michael,

On Thu, Aug 21, 2008 at 1:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Aug 20, 2008 at 11:09:27PM -0400, Ronald S. Bultje wrote:
>> Hi Michael,
>>
>> On Wed, Aug 20, 2008 at 10:42 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Aug 20, 2008 at 02:03:12PM -0400, Ronald S. Bultje wrote:
>> >> Hi,
>> >>
>> >> tcpmemleak.patch: I think the malloc should go after the init &
>> >> paramchecks otherwise the return in ff_network_init() could be a
>> >> memleak. In tcp.c, I move the malloc down,
>> >
>> > i think it should be moved over all goto fail* which would allow
>> > the fail case to be simplified
>>
>> Hm, ok, like $attached?

What about the first patch?

Ronald