[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

[Ronald S. Bultje]

Hi,

On Fri, Aug 22, 2008 at 6:03 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Aug 22, 2008 at 05:26:45PM -0400, Ronald S. Bultje wrote:
>> Hi Michael,
>>
>> On Thu, Aug 21, 2008 at 1:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Wed, Aug 20, 2008 at 11:09:27PM -0400, Ronald S. Bultje wrote:
>> >> Hi Michael,
>> >>
>> >> On Wed, Aug 20, 2008 at 10:42 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > On Wed, Aug 20, 2008 at 02:03:12PM -0400, Ronald S. Bultje wrote:
>> >> >> Hi,
>> >> >>
>> >> >> tcpmemleak.patch: I think the malloc should go after the init &
>> >> >> paramchecks otherwise the return in ff_network_init() could be a
>> >> >> memleak. In tcp.c, I move the malloc down,
>> >> >
>> >> > i think it should be moved over all goto fail* which would allow
>> >> > the fail case to be simplified
>> >>
>> >> Hm, ok, like $attached?
>>
>> What about the first patch?
>
> that mixes unrelated changes as well

Sorry, I thought you wanted that in the same patch. Here's just the
move of ff_network_init() to prevent the memleak. The rest will come
in small patches separately.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tcpmemleak.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/82a99e74/attachment.asc>