[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi,

On Fri, Aug 22, 2008 at 4:06 PM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
> [...]
>>> I think that we should only use standard tags here (and not the "RMFF",
>>> "OpaqueData", "ASMRuleBook", ... keywords used by real). Can you just
>>> call parse_sdp_a_line() in the final "else" case (without checking for
>>> any particular tag)? Then, you can check for the real tags in the
>>> rdt_parse_sdp_line() function.
>>
>> So s/else if(..||..||..)/else/? Sure, no problem.
>
> Yes... Does this work for you?
> Index: libavformat/rtsp.c
> ===================================================================
> --- libavformat/rtsp.c  (revision 14908)
> +++ libavformat/rtsp.c  (working copy)
> @@ -527,6 +527,12 @@
>              rtsp_parse_range_npt(p, &start, &end);
>              s->start_time= start;
>              s->duration= (end==AV_NOPTS_VALUE)?AV_NOPTS_VALUE:end-start; // AV_NOPTS_VALUE means live broadcast (and can't seek)
> +        } else if (s->nb_streams) {
> +            st = s->streams[s->nb_streams - 1];
> +            rtsp_st = st->priv_data;
> +            if (rtsp_st->dynamic_handler && rtsp_st->dynamic_handler->parse_sdp_a_line) {
> +                rtsp_st->dynamic_handler->parse_sdp_a_line(st, rtsp_st->dynamic_protocol_context, buf);
> +            }
>          }
>          break;
>      }
> (clearly, you have to move "AvgBitRate" handling in rdt_parse_sdp_line())

The attached patch changes the prototype for parse_sdp_a_line() and
adds the else case as per above.

Ronald
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: parse_sdp_a_line.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080822/db6e9006/attachment.txt>