[FFmpeg-devel] [PATCH] tcp.c/udp.c memleak?

[Ronald S. Bultje]

Hi Michael,

On Sat, Aug 23, 2008 at 2:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Aug 23, 2008 at 01:50:35PM -0400, Ronald S. Bultje wrote:
>> @@ -104,7 +105,6 @@
>>   fail:
>>      ret = AVERROR(EIO);
>>   fail1:
>> -    if (fd >= 0)
>>          closesocket(fd);
>>      return ret;
>>  }
>
> I have a bad feeling about this
> its easy to add a new goto fail and forget that there is no check for fd

OK, I applied this one without this chunk, I don't think it's important.

Ronald