[FFmpeg-devel] [PATCH] make id3v1_genre_str array const

Reimar Döffinger Reimar.Doeffinger
Sun Aug 24 08:54:15 CEST 2008


Hello,
I guess someone forgot one const for this table.
There are similar cases in isom.c, matroskadec.c and utils.c as well as in libavcodec
eval.c and possibly a cast in h264.c (which IMHO is exceedingly ugly anyway) that
the maintainers can probably fix faster than I ;-).
I found them by doing
grep "const char *.*\[\]" *

Greetings,
Reimar D?ffinger
-------------- next part --------------
Index: libavformat/mp3.c
===================================================================
--- libavformat/mp3.c	(revision 14905)
+++ libavformat/mp3.c	(working copy)
@@ -30,7 +30,7 @@
 
 #define ID3v1_GENRE_MAX 125
 
-static const char *id3v1_genre_str[ID3v1_GENRE_MAX + 1] = {
+static const char * const id3v1_genre_str[ID3v1_GENRE_MAX + 1] = {
     [0] = "Blues",
     [1] = "Classic Rock",
     [2] = "Country",



More information about the ffmpeg-devel mailing list