[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Sun, Aug 24, 2008 at 09:55:53PM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Thu, Aug 21, 2008 at 12:05 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Aug 18, 2008 at 10:21:35AM -0400, Ronald S. Bultje wrote:
> [..]
> >> +    hex_table[16] = { '0', '1', '2', '3', '4', '5', '6', '7',
> >> +        '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
> [..]
> >> +    /* convert zres to ascii string */
> >> +    for (i = 0; i < 16; i++) {
> >> +        response[i * 2]     = hex_table[zres[i] >> 4];
> >> +        response[i * 2 + 1] = hex_table[zres[i] & 0xf];
> >> +    }
> >
> > grep hex */*.c shows that there are several existing data->hex converters
> > thus this is duplicate
> 
> Attached patch exports the existing one in sdp.c into utils.c with
> declaration in avformat.h.

avformat.h is a public header the function is not supposed to be public.

besides this is not exporting it is removing and adding a different one.
That should be 2 patches
* move
* change implementation


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080825/bdd80857/attachment.pgp>