[FFmpeg-devel] [PATCH] remove useless math.h include in libavutil/mathematics.h

[Guillaume Poirier]

Hello folks,

I noticed that the include of math.h in libavutil/mathematics.h doesn't
seem to be usefull.
Well, in fact, it leads to a compile of MPlayer on OSX 10.4...

I know that ffmpeg shouldn't work around MPlayer problems, but since
FFmpeg compiles fine after this patch is applied, and it fixed the
problem, I though it was worth submitting a patch.

Here's what GCC says:
cc -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -I. -Wall -Wno-switch
-Wpointer-arith -Wredundant-decls -O4 -mcpu=7450 -mtune=7450 -pipe
-ffast-math -fomit-frame-pointer -maltivec -mabi=altivec
-mdynamic-no-pic -falign-loops=16 -shared-libgcc -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -I/sw/include
-I/usr/local/include -I/usr/X11R6/include -I/sw/include -I/sw/include  
-c -o liba52/parse.o liba52/parse.c
In file included from /usr/include/math.h:26,
                from ./libavutil/mathematics.h:25,
                from ./libavutil/avutil.h:57,
                from liba52/parse.c:40:
/usr/include/architecture/ppc/math.h:179: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:179: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:180: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:180: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:181: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:181: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:182: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:182: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:183: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:183: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:184: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:184: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:185: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:185: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:186: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:186: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:187: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:187: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:188: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:188: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:189: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:189: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:190: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:190: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:191: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:191: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:192: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:192: error: parse error before 'inline'
/usr/include/architecture/ppc/math.h:193: error: parse error before
'__attribute__'
/usr/include/architecture/ppc/math.h:193: error: parse error before 'inline'
make: *** [liba52/parse.o] Error 1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OSX-1.4.44-PPC-fix.diff
Type: text/x-patch
Size: 315 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080825/02c676d9/attachment.bin>