[FFmpeg-devel] [RFC][PATCH] move _ISOC9X_SOURCE

[Kurtnoise]

Hi,

Michael Niedermayer a ?crit :
> On Thu, Aug 14, 2008 at 03:13:32AM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>
>>> On Thu, Aug 14, 2008 at 02:50:35AM +0200, Michael Niedermayer wrote:
>>>> On Wed, Aug 13, 2008 at 05:25:08PM -0700, Baptiste Coudurier wrote:
>>>>> Im pretty sure we are using functions defined in POSIX 2001, but not in
>>>>> earliers revisions.
>>>>>
>>>>> 'strcasecmp' is an example:
>>>>> CONFORMING TO
>>>>>        4.4BSD, POSIX.1-2001.
>>>> well it passed compilation and make test and i didnt spot any large amounts
>>>> of implicit declaration warnings ...
>>>> also strcasecmp is not under any POSIX_C_SOURCE #ifdef in the gnu headers
>>>> so i do not think simply compiling and looking for implicit declaration
>>>> warnings would be reliable
>>>>
>>>> iam fine with someone adding -D_POSIX_C_SOURCE=200112 ...
>>>> (though ive sent enough patches for that today, i rather should try to
>>>>  fix the remaining conformance streams for h.264 between the soc patches)
>>> ok changed my mind, last patch for today below:
>>>
>>> Index: configure
>>> ===================================================================
>>> --- configure	(revision 14745)
>>> +++ configure	(working copy)
>>> @@ -974,7 +974,7 @@
>>>  vhook="default"
>>>
>>>  # build settings
>>> -add_cflags -D_ISOC99_SOURCE
>>> +add_cflags -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112
>>>  SHFLAGS='-shared -Wl,-soname,$$(@F)'
>>>  VHOOKSHFLAGS='$(SHFLAGS)'
>>>  FFSERVERLDFLAGS=-Wl,-E
>> OK
> 
> applied
> 
Well...it seems that compilation fails with an external lib (PTHREADS) 
here using this patch, at least on my mingw32 install. Some people on 
ffmpeg-users ML have also reported the same problem [1]. So, I'm not the 
only one.

What do you suggest to fix it ? I mean, is there a better patch to 
revert at the previous flags ?

[1]: http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-August/016749.html