[FFmpeg-devel] split 3iv1 from h263.c

Michael Niedermayer michaelni
Wed Aug 27 13:51:06 CEST 2008


On Wed, Aug 27, 2008 at 08:30:16AM +0200, Diego Biurrun wrote:
> On Tue, Aug 26, 2008 at 07:21:22PM -0400, compn wrote:
> > i saw diego split mdec from mpeg12 file
> > just wondering if the same could be done for 3iv1 ?
> > 
> > any other codecs need their own file ?
> 
> According to what I understood from what you said on IRC, I think the
> question you are trying to ask is the following one:
> 
> Why is 3IV1 disabled in libavcodec/h263.c?
> 
> #if 0 //3IV1 is quite rare and it slows things down a tiny bit
> #define IS_3IV1 s->codec_tag == ff_get_fourcc("3IV1")
> #else
> #define IS_3IV1 0
> #endif
> 
> Has anybody run any benchmarks lately?

not me but

s/IS_3IV1/ENABLE_3IV1 && s->codec_tag == ff_get_fourcc("3IV1")/

seems cleaner now, (IS_3IV1 predates the codec enabling/disabling stuff ...)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/68106338/attachment.pgp>



More information about the ffmpeg-devel mailing list