[FFmpeg-devel] Realmedia patch

[Michael Niedermayer]

On Wed, Aug 27, 2008 at 09:06:44AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Aug 27, 2008 at 8:43 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > inOn Wed, Aug 27, 2008 at 08:39:11AM -0400, Ronald S. Bultje wrote:
> >> Hi Michael,
> >>
> >> On Wed, Aug 27, 2008 at 8:27 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > Let me try again :(
> >> >
> >> > ff_data_to_hex must not be in a public header not directly or indirectly.
> >> > NO public header must EVER include a non public header.
> >> > avformat.h is a public header
> >>
> >> Sorry, the same scheme is used in lavu/common.h, I just moved on from there...
> >
> > no
> >
> > lavu/common.h
> > uses:
> > #ifdef HAVE_AV_CONFIG_H
> > #    include "internal.h"
> > #endif /* HAVE_AV_CONFIG_H */
> >
> > So it only includes the internal header when common.h is used internally
> 
> Same here, see grep HAVE_AV_CONFIG_H libavformat/avformat.h.

hmm, true

Still IMHO its clearer if internal.h is included directly instead of over
a public headetr when HAVE_AV_CONFIG_H is defined.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/bef73043/attachment.pgp>