[FFmpeg-devel] [PATCH] specify a name/description per stream

[Michael Niedermayer]

On Wed, Aug 27, 2008 at 09:04:32PM +0200, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> 
> > On Wed, Aug 27, 2008 at 08:04:13PM +0200, Aurelien Jacobs wrote:
> > [...]
> > > > > [...]
> > > > >  
> > > > > Index: libavformat/avformat.h
> > > > > ===================================================================
> > > > > --- libavformat/avformat.h	(revision 14980)
> > > > > +++ libavformat/avformat.h	(working copy)
> > > > > @@ -409,6 +409,8 @@
> > > > >       * - decoding: Set by libavformat.
> > > > >       */
> > > > >      AVRational sample_aspect_ratio;
> > > > > +
> > > > > +    char *name;  /**< name/description of the track */
> > > > >  } AVStream;
> > > > 
> > > > Maybe char name[1024] is preferrable, like all other metadata in
> > > > AVFormatContext ?
> > > 
> > > I tried to be consistent with other fields in AVStream, such as
> > > filename. If an array is really preferred I can change it.
> > > Any other opinion about this.
> > 
> > a more generic metadata API may be interresting
> > Especially with user specified keys instead of "name" "author", ...
> > the current system would break down.
> 
> I agree that a more generic metadata API would be useful.
> But you should note that my current patch is not about adding
> a new metadata field in AVFormatContext. It's about adding a
> specific field in AVStream.
> Well, I guess that a generic metadata API could also be used
> per stream, but I wonder if this wouldn't be overkill. 

per stream, per chapter, per program, per file, ...


> I doubt
> that any muxer could really fully benefit from it.

nut would have no problem with it :)


> So do you place the generic metadata API as a strong requirement
> to export the stream name, or would my patch be an acceptable way
> to do it, at least in the mean time ?

generic metadata is not a strong requirement but things slowly become
messy without it
char [1024] vs char * being one, and iam in favor of char * i think
Or
how much metadata is lost when remuxing currently?
Or
What language is the metadata in

Besides, iam not sure if i just missed it when reading the thread but
what exactly is a name of a stream ? Also iam curious about some
examples about what value it would have before approving this ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/aef8f47b/attachment.pgp>