[FFmpeg-devel] Realmedia patch

Luca Abeni lucabe72
Thu Aug 28 17:56:34 CEST 2008


Hi Ronald,

Ronald S. Bultje wrote:
[...]
> Index: ffmpeg-svn/libavformat/rtsp.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rtsp.c	2008-08-27 19:03:58.000000000 -0400
> +++ ffmpeg-svn/libavformat/rtsp.c	2008-08-28 09:06:31.000000000 -0400
> @@ -42,6 +42,12 @@
>      RTSP_STATE_PAUSED,
>  };
>  
> +enum RTSPServerType {
> +    RTSP_SERVER_RTP = 0, /*< Standard-compliant RTP-server */

It's still not clear why "= 0". If this assignment is not needed, I'd say to
remove it. After this, I think the patch is ok. If it works and if noone
complains in 2 or 3 days, commit it (in three different steps).


				Luca




More information about the ffmpeg-devel mailing list