[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:

> Hi,
>
> Loren Merritt wrote:
>> On Fri, 29 Aug 2008, Stefano Sabatini wrote:
>> 
>>> -    x4->params.rc.psz_rc_eq = avctx->rc_eq;
>>> +#if X264_BUILD < 61
>>> +    if (avctx->rc_eq)
>>> +        x4->params.rc.psz_rc_eq = avctx->rc_eq;
>>> +#else
>>> +        av_log(avctx, AV_LOG_WARNING, "Ignoring the rc_eq set, using the libx264 default one\n");
>>> +#endif
>> 
>> Unconditionally print a warning if it's compiled with new libx264?
>> 
>
> I'd say no ifdefery, remove the line.

Agree.

-- 
M?ns Rullg?rd
mans at mansr.com