[FFmpeg-devel] Realmedia patch

[Ronald S. Bultje]

Hi Luca,

On Sat, Aug 30, 2008 at 11:27 AM, Luca Abeni <lucabe72 at email.it> wrote:
> Ronald S. Bultje wrote:
>> On Sat, Aug 30, 2008 at 6:30 AM, Luca Abeni <lucabe72 at email.it> wrote:
>>> Ronald S. Bultje wrote:
>>> [...]
>>>> @@ -918,7 +920,9 @@
>>>>              if (transport[0] != '\0')
>>>>                  av_strlcat(transport, ",", sizeof(transport));
>>>>              snprintf(transport + strlen(transport), sizeof(transport) - strlen(transport) - 1,
>>>> -                     "RTP/AVP/UDP;unicast;client_port=%d-%d",
>>>> +                     "%s;unicast;client_port=%d-%d",
>>> Is "client_port=%d-%d" really needed here, or would "client_port=%d"
>>> be enough? (RDT does not seem to have an RTCP-like companion protocol)
[..]
>> (i.e. in the case of audio+video, they
>> stream over a separate UDP session with separate port).
>
> I am not sure about this... If I understand well, you will see a single
> "m=" line, and both audio and video streams will be muxed inside the RM
> stream.

No, there's no RM-level muxing going on.

>> So I think it
>> is needed. (This is of course in the theoretical case that Realmedia
>> RDT supports UDP - you and I both have seen only TCP-supporting
>> servers...)
>
> Note that there is a "SETUP" request per stream (one setup per "m=" line
> in the SDP). So, the "%d-%d" looks wrong (this is why I asked).

Oh, right, I see. Don't forget the %d-%d is there for RTP also, by the
way, and I don't really have a working Real-UDP stream, so I find it
hard to test this. If you want, I can just change it, but it'll lead
to slightly uglier code. Let me know if that's OK.

Ronald