[FFmpeg-devel] [PATCH] codec_has_pameters and sample_fmt

[Michael Niedermayer]

On Sat, Aug 30, 2008 at 02:04:30PM +1000, Peter Ross wrote:
> On Fri, Aug 29, 2008 at 11:04:43PM +0200, Michael Niedermayer wrote:
> > On Fri, Aug 29, 2008 at 01:08:50PM -0700, Baptiste Coudurier wrote:
> > > Hi
> > > 
> > > I think codec_has_parameters should return true only if sample_fmt has
> > > been determined for audio codecs.
> > > 
> > > It seems libavcodec still sets it to S16 atm, so it does no harm,
> > > however this will be needed.
> > 
> > patch ok
> > 
> > 
> > > 
> > > I missed a bit this thread, but when will avcodec set sample_fmt to NONE
> > > by default ?
> > 
> > when peter changes it, IIRC ive approved it being changed as soon as
> > it does work ...
> 
> The seemingly innocent S16->NONE change breaks the seek regression test
> for AC3 (within RM container). I have enclosed fix this *but* i am not
> really sure "why" this fixes it. Ideas, anyone?

Well i can just guess and that really is just a guess ...
there may be some issue (maybe a bug but maybe just something unexpected)
with seeking and the parser in respect to rm.
And this bug could be triggered by how far av_find_stream_info() reads
which may be affected by the lack of sample_fmt.
But again this is a far fetched guess and could be totally off

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080830/ee17f4e2/attachment.pgp>