[FFmpeg-devel] [PATCH] Make a clear distinction between an unsupported codec and an unknown one

[Michael Niedermayer]

On Sun, Aug 31, 2008 at 06:56:48AM +0200, Vitor Sessak wrote:
> See $subj. I got pretty confused by "Stream #0.1: Audio: 0x0000, 5512 Hz, 
> mono, s16" meaning that a codec is known, but unsupported...
>
> -Vitor

> Index: libavcodec/utils.c
> ===================================================================
> --- libavcodec/utils.c	(revision 15050)
> +++ libavcodec/utils.c	(working copy)
> @@ -1091,8 +1091,12 @@
>                       (enc->codec_tag >> 16) & 0xff,
>                       (enc->codec_tag >> 24) & 0xff,
>                        enc->codec_tag);
> +        } else if (enc->codec_id) {
> +            snprintf(buf1, sizeof(buf1), "unsuported (id 0x%04x)", enc->codec_id);
> +        } else if (enc->codec_tag) {
> +            snprintf(buf1, sizeof(buf1), "unknown (0x%04x)", enc->codec_tag);
>          } else {
> -            snprintf(buf1, sizeof(buf1), "0x%04x", enc->codec_tag);
> +            snprintf(buf1, sizeof(buf1), "unknown");
>          }

I think this is inconsistant now
Before it just printed the tag now it prints the tag when its
printable, if not and codec_id is not 0 the id and if not and
id is 0 and the tag is not 0 the tag and ...
Printing the ID in addition to the tag and "NONE" instead of
0x0000 or so seems more consistent to me

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080831/f43829c0/attachment.pgp>