[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Dec 1, 2008, at 12:48 PM, Vitor Sessak wrote:

> Kenan Gillet wrote:
>> Hi,
>> On Mon, Dec 1, 2008 at 8:24 AM, Michael Niedermayer  
>> <michaelni at gmx.at> wrote:
>>> On Mon, Dec 01, 2008 at 08:17:52AM -0800, Kenan Gillet wrote:
>>>> On Dec 1, 2008, at 4:52 AM, Michael Niedermayer wrote:
>>>>
>>>>> On Sun, Nov 30, 2008 at 05:04:07PM -0800, Kenan Gillet wrote:
>>>>>> Hi,
>>>>>> On Nov 30, 2008, at 7:50 AM, Michael Niedermayer wrote:
>>>>>>
>>>>>>> On Sat, Nov 29, 2008 at 10:39:58AM -0800, Kenan Gillet wrote:
>>> [...]
>>>>> [...]
>>>>>>>> +    /**
>>>>>>>> +     * reserved bits on all bitrate but bitrate 1/2 packets
>>>>>>> this is unclear, field that is on all but ... , vs. field that
>>>>>>> exists always but
>>>>>>> is reserved on all but .....
>>>>>>>
>>>>>> is "reserved bits only set for bitrate 1, 1/4 and 1/8" better ?
>>>>> no, because setting them means error IIRC
>>>>> also IIRC there is no indication of the existence of other fields
>>>>> for the
>>>>> other rates ...
>>>>>
>>>> reserved bits only present in bitrate 1, 1/4 and 1/8 packets
>>>>
>>>> ?
>>> ok
>>>
>>> [...]
>>
>> here is an updated round 14 of the patches,
>> which is getting smaller and smaller :)
>
>>
>> Index: libavcodec/qcelpdata.h
>> ===================================================================
>> --- libavcodec/qcelpdata.h	(revision 15972)
>> +++ libavcodec/qcelpdata.h	(working copy)
>> @@ -58,6 +58,10 @@
>>      */
>>     uint8_t lspv[10];
>>
>> +    /**
>> +     * reserved bits only present in bitrate 1, 1/4 and 1/8 packets
>> +     */
>> +    uint8_t reserved;
>> } QCELPFrame;
>>
>> /**
>> @@ -76,8 +80,6 @@
>>
>> #define QCELP_OF(variable, bit, len) {offsetof(QCELPFrame,  
>> variable), bit, len}
>>
>> -/* Disable the below code for now to allow 'make checkheaders' to  
>> pass. */
>> -#if 0
>> /**
>>  * bitmap unpacking tables for RATE_FULL
>>  *
>> @@ -277,7 +279,6 @@
>>     FF_ARRAY_ELEMS(qcelp_rate_half_bitmap),
>>     FF_ARRAY_ELEMS(qcelp_rate_full_bitmap),
>> };
>> -#endif
>>
>> typedef uint16_t qcelp_vector[2];
>
> I beat you at this hunk =)

hats off, impressive reaction time :)

and thank you for all the commits

Kenan