[FFmpeg-devel] [PATCH] remove useless extern keywords

[Diego Biurrun]

On Wed, Dec 03, 2008 at 04:54:55PM +0100, Michael Niedermayer wrote:
> On Wed, Dec 03, 2008 at 03:05:00PM -0000, M?ns Rullg?rd wrote:
> > 
> > Diego Biurrun wrote:
> > > On Tue, Dec 02, 2008 at 01:32:36AM +0000, M?ns Rullg?rd wrote:
> > >> Diego Biurrun <diego at biurrun.de> writes:
> [...]
> > >> > --- libavformat/mpegts.c	(revision 15974)
> > >> > +++ libavformat/mpegts.c	(working copy)
> > >> > @@ -38,8 +38,8 @@
> > >> >
> > >> >  static PESContext* add_pes_stream(MpegTSContext *ts, int pid, int
> > pcr_pid, int stream_type);
> > >> >  static AVStream* new_pes_av_stream(PESContext *pes, uint32_t code);
> > >> > -extern void av_set_program_name(AVProgram *program, char *provider_name,
> > char *name);
> > >> > -extern void av_program_add_stream_index(AVFormatContext *ac, int progid,
> > unsigned int idx);
> > >> > +void av_set_program_name(AVProgram *program, char *provider_name, char
> > *name);
> > >> > +void av_program_add_stream_index(AVFormatContext *ac, int progid,
> > unsigned int idx);
> > >>
> > >> Those declarations don't belong there at all.  The definitions are in
> > >> utils.c.  I don't know what the proper place would be.  Michael?
> > >
> > > avformat.h?  internal.h?  Depends on whether these are supposed to be
> > > exported or not.
> > 
> > Exporting them makes no sense.  They are only of use in a demuxer.
> 
> what about muxing?
> I dont think any muxer is writing program infos but in principle they should
> and then these could be used by a user app ...
> 
> either way, ia definitly in favor to put them in internal.h ATM, until
> there actually is some sense in exporting them ...

Done.

Diego