[FFmpeg-devel] [PATCH] asf.c: move packet_time_start=0 statement

[Michael Niedermayer]

On Sat, Dec 06, 2008 at 02:41:26PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Dec 4, 2008 at 10:34 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Dec 04, 2008 at 08:44:18AM -0500, Ronald S. Bultje wrote:
> >> +    for (;;) {
> >> +        int ret;
> >> +
> >> +        /* parse cached packets, if any */
> >> +        if ((ret = asf_parse_packet(s, pkt)) <= 0)
> >> +            return ret;
> >
> >> +        else if ((ret = asf_get_packet(s)) < 0) {
> >
> > you dont need the else
> 
> Fixed.
> 
> [..]
> > and i assume you have tested this patch with normal asf/wma/wmv and the
> > regression tests?
> 
> It fails both before and after for one file, a WMA file, with this:
> 
> @@ -205,7 +205,7 @@
>  353368 ./tests/data/a-flac.flac
>  95e54b261530a1bcf6de6fe3b21dc5f6 *./tests/data/flac.vsynth.out.wav
>  stddev:    0.00 PSNR:999.99 bytes:  1058444/  1058444
> -4435d87463cd6c5407bd88cca241ca56 *./tests/data/a-wmav1.asf
> +6f7f3116b801ea641ce14f827de05cce *./tests/data/a-wmav1.asf
>  106004 ./tests/data/a-wmav1.asf
>  stddev:12251.38 PSNR: 14.56 bytes:  1056812/  1058444
>  stddev: 2105.96 PSNR: 29.85 bytes:  1048620/  1058444
> 
> This is because of the non-fixed point WMA impl, as referenced earlier here:
> 
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-November/056294.html
> (see your reply to that email also)
> 
> (and several other times for the same MD5sum.) Maybe both md5s should
> be accepted as OK? this is on MacOSX 10.4, with:

thats a problem because if it fails there, it  doesnt run (and cant actually
run) the following tests like the test that tests seeking in the files.
Thus this does not count as passing regressions

You will either have to fix the wma issue (one way or another, many have been
suggested ...) or find some volunteer to run regression tests for you

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081206/8bfd309a/attachment.pgp>