[FFmpeg-devel] In Leopard library is broken if compiled with Tiger compatibility

[Måns Rullgård]

?????????? ??????????? <panayotis at panayotis.com> writes:

> In Mac OS X 10.5, in order to produce binary compatible code with  
> version 10.4, there is a need to manually add the command line argument
> -mmacosx-version-min=10.4
> or else the produced code will not be binary compatible with previous  
> version.
>
> This works with ffmpeg, e.g. by using the "--extra-cflags"  
> configuration option, but unfortunately, this is not enough. The  
> produced code is still not compatible (there are some *$UNIX2003  
> symbols presented).
>
> I did some exploration and managed to spot the source of the problem,  
> in case you are willing to address it.
>
> * 1 *
>
> In libavcodec/utils.c line 29
> There is a #define which forces specific features for mkstemp
> This define breaks "strtod" function in line 1501
>
> Thus, I propose something like
>
> #ifndef __APPLE__
> #define _XOPEN_SOURCE 600
> #endif
>
> instead of
> #define _XOPEN_SOURCE 600
>
> (or even better enable this flag ONLY in systems where are really  
> needed.
>
> * 2 *
>
> In configure script, line 1130
>
> There is a line saying
> add_cflags -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112
>
> Unfortunately the flag _POSIX_C_SOURCE breaks compatibility, and I'd  
> suggest again to be added only when is really needed.
>
> Thank you for listening to me. 

The Apple build system is broken.  There's nothing we can do about that.

-- 
M?ns Rullg?rd
mans at mansr.com


>From =?UTF-8?B?zqDOsc69zrHOs865z47PhM63z4IgzprOsc+Ez4POsc67zr/Pjc67?=  Sun Dec  7 14:13:22 2008
From: =?UTF-8?B?zqDOsc69zrHOs865z47PhM63z4IgzprOsc+Ez4POsc67zr/Pjc67?= (=?UTF-8?B?zqDOsc69zrHOs865z47PhM63z4IgzprOsc+Ez4POsc67zr/Pjc67?=)
Date: Sun, 7 Dec 2008 15:13:22 +0200
Subject: [FFmpeg-devel] In Leopard library is broken if compiled with
	Tiger compatibility
In-Reply-To: <yw1xk5acxhs3.fsf at thrashbarg.mansr.com>
References: <AB08EDC6-8DEE-456A-8E3B-2A3B78D03254 at panayotis.com>
	<yw1xk5acxhs3.fsf at thrashbarg.mansr.com>
Message-ID: <D2800AF4-5846-40C2-8DA0-02B1610FEA23 at panayotis.com>


On 07 ??? 2008, at 2:59 ??, M?ns Rullg?rd wrote:

> ?????????? ??????????? <panayotis at panayotis.com>  
> writes:
>
>> In Mac OS X 10.5, in order to produce binary compatible code with
>> version 10.4, there is a need to manually add the command line  
>> argument
>> -mmacosx-version-min=10.4
>> or else the produced code will not be binary compatible with previous
>> version.
>>

...

> The Apple build system is broken.  There's nothing we can do about  
> that.
>

As most systems. Windows for example ;)

Yes there is, I even included a proposed solution. If you don't want  
to do anything, even with a solution provided, it's another thing.