[FFmpeg-devel] [PATCH] high precision mp3 decoding needs CONFIG_AUDIO_NONSHORT which is never set

[Benoit Fouet]

On 12/08/2008 12:10 PM, Diego Biurrun wrote:
> On Mon, Dec 08, 2008 at 10:00:57AM +0100, Benoit Fouet wrote:
>   
>> On 12/07/2008 03:25 PM, Michael Niedermayer wrote:
>>     
>>> On Sun, Dec 07, 2008 at 02:51:57PM +0100, Mathieu Velten wrote:
>>>   
>>>       
>>>> patch attached
>>>>         
>>> looks ok
>>>       
>> reg tests fail here with this patch:
>>     
>
> Do they also fail if you make the change in both mpegaudiodec.c and
> mpegaudio.h?
>
>   

yes, they also fail

diff -u -w "/home/fouet/tools/ffmpeg"/tests/libav.regression.ref
tests/data/lavf.regression
--- /home/fouet/tools/ffmpeg/tests/libav.regression.ref    2008-12-03
17:30:27.000000000 +0100
+++ tests/data/lavf.regression    2008-12-08 12:22:49.000000000 +0100
@@ -1,23 +1,23 @@
 8a0536ccfe36f4fff408b3327d33e1dd *./tests/data/b-libav.avi
 340344 ./tests/data/b-libav.avi
-./tests/data/b-libav.avi CRC=0x400c29e9
+./tests/data/b-libav.avi CRC=0xdf624a58
 bd9e0012aa39e956605387dd499365fb *./tests/data/b-libav.asf
 339775 ./tests/data/b-libav.asf
-./tests/data/b-libav.asf CRC=0x74113749
+./tests/data/b-libav.asf CRC=0x137657b8
 c351132527ccb1e8cab06cc0822fde23 *./tests/data/b-libav.rm
 355417 ./tests/data/b-libav.rm
 bdb7484c68db722f66ba1630cf79844c *./tests/data/b-libav.mpg
 378880 ./tests/data/b-libav.mpg
-./tests/data/b-libav.mpg CRC=0x2b71a386
+./tests/data/b-libav.mpg CRC=0xfb7cc3f5
 447b005e527cf495ec13092e788f028d *./tests/data/b-libav.ts
 471692 ./tests/data/b-libav.ts
-./tests/data/b-libav.ts CRC=0xcc4948e1
+./tests/data/b-libav.ts CRC=0x6bae6950
 1b28a16652bb8ac528b33f7478ca18b6 *./tests/data/b-libav.swf
 335771 ./tests/data/b-libav.swf
 ./tests/data/b-libav.swf CRC=0xe14e8847
 3dbacdc3fccb551f8ab54c32f648e7a8 *./tests/data/b-libav.ffm
 380928 ./tests/data/b-libav.ffm
-./tests/data/b-libav.ffm CRC=0x2b71a386
+./tests/data/b-libav.ffm CRC=0xfb7cc3f5
 f8ad5bd78f4d012a8ce9570aa395ac54 *./tests/data/b-libav.flv
 335833 ./tests/data/b-libav.flv
 ./tests/data/b-libav.flv CRC=0xe14e8847
@@ -32,10 +32,10 @@
 ./tests/data/b-libav.gxf CRC=0x9c06676e
 66a6584f9e83e8ea3af822a3ba71fbbe *./tests/data/b-libav.nut
 329264 ./tests/data/b-libav.nut
-./tests/data/b-libav.nut CRC=0x400c29e9
+./tests/data/b-libav.nut CRC=0xdf624a58
 eae326ecf213a6f2ffb71a8a7afc5ef1 *./tests/data/b-libav.mkv
 329803 ./tests/data/b-libav.mkv
-./tests/data/b-libav.mkv CRC=0x400c29e9
+./tests/data/b-libav.mkv CRC=0xdf624a58
 af195c31e8f49de61e3851ccde4c3ebd *./tests/data/b-pbmpipe.pbm
 317075 ./tests/data/b-pbmpipe.pbm
 ./tests/data/b-pbmpipe.pbm CRC=0x1ac46c70


Ben