[FFmpeg-devel] [PATCH] define _BSD_SOURCE for bktr.c

[Reimar Döffinger]

On Sun, Dec 14, 2008 at 11:06:48PM +0000, Jacob Meuser wrote:
> no offense taken.  you are correct.  the only patch I was unsure of
> was removing ff_check_alignment.  but a) that can fail anyway, and
> b) I did ask some OpenBSD developers about this, and was told
> the check was probably not necessary.  I'm pretty sure I asked here
> about that as well.

ff_check_alignment is not reliable and it does not fix anything, it just
alerts the user.
Nevertheless, the insufficient alignment could explain some of the
regression test failures I see.
Unfortunately I can't really know, currently ffmpeg does not compile
with the gcc 4.2 OpenBSD package and I am not motivated to compile
gcc on my own right now.
I can say that these tests do not fail on FreeBSD though...

> I also tried really hard to keep ffmpeg up to date.  before I started
> working on it, OpenBSD was shipping 0.4.9-pre1 or whatever it was,
> years after that "release" ...

Well, given that they use gcc 3.3 and as 2.15 I guess that's not so
bad... somehow... (GNU as 2.15 (also shipped by FreeBSD) btw. can't
compile FFmpeg's cabac assembler for 64 bit. The reason is that
%eax is used as address offset - somehow newer versions seem to silently
convert that to %rax).

Greetings,
Reimar D?ffinger