[FFmpeg-devel] [PATCH] Port x264 SSE2 deblocking code to H.264 decoder

[Michael Niedermayer]

On Tue, Dec 16, 2008 at 04:56:52PM -0800, Jason Garrett-Glaser wrote:
[...]
> > I belive that whatever license header this file shall carry, it should not
> > differ between the file in x264 and ffmpeg.
> 
> I just copied the one from ffmpeg used in the ac3 encoder.

Please leave the header as it is in x264, this makes future
merges easier.


> 
> > why?
> 
> I was copying the syntax used in dsputil_yasm.asm.

well i suggest you leave the syntax as it was in x264 unless there is some
good reason to change it.


[...]
> 
> > why is all this code ommited?
> 
> The MMXEXT code is omitted because ffh264 already has mmxext
> implementations of those which are quite similar, so I figured there
> was no point in wasting code space (as the ffh264 are LGPL and
> therefore preferred).

ok


> 
> I skipped luma_intra for now as I saw no asm implementation at all in
> ffh264, but yes, I should probably add that back in.

i think you could just leave functions that likely will b used in the
future in the file.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081217/f741f1db/attachment.pgp>